Re: bug in plancache.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: yamt(at)mwd(dot)biglobe(dot)ne(dot)jp (YAMAMOTO Takashi)
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: bug in plancache.c
Date: 2011-09-26 16:45:58
Message-ID: 9261.1317055558@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

yamt(at)mwd(dot)biglobe(dot)ne(dot)jp (YAMAMOTO Takashi) writes:
> GetCachedPlan can pass the 'qlist' to the planner twice.
> if i understand the code correctly, it's unsafe because the planner is
> destructive wrt the input tree. for my application, it often causes
> a crash in executor.

Good catch, thanks! (But a fix like this really requires a comment IMO.)

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2011-09-26 17:14:40 Re: comment fixes
Previous Message Tom Lane 2011-09-26 16:39:26 Re: BUG #6222: Segmentation fault on unlogged table