| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog, |
| Date: | 2009-02-11 14:50:34 |
| Message-ID: | 9190.1234363834@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane wrote:
>> Personally I'd be more worried about the unnest(). Also, please
>> schema-qualify that function name; you can't assume anything about
>> the search path here.
> Maybe it would be more elegant to put the search_path into proconfig?
This is psql's describe.c, not a sql function. It hasn't got a
proconfig, and it doesn't seem like a particularly good idea to make
it try to replace the user's search path setting directly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Achernow | 2009-02-11 15:03:36 | libpqtypes - libpqtypes: Fixed empty array issue, getf always returned a |
| Previous Message | Peter Eisentraut | 2009-02-11 14:03:43 | pgsql: Only unset the locale environment when --no-locale is used (the |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2009-02-11 14:53:36 | Re: [PATCHES] GIN improvements |
| Previous Message | Bernd Helmle | 2009-02-11 14:49:24 | HotStandby vs. flatfile updates |