Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #2195: log_min_messages crash server when in DEBUG3 to

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Milen A(dot) Radev" <milen(at)radev(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #2195: log_min_messages crash server when in DEBUG3 to
Date: 2006-01-31 20:26:03
Message-ID: 9091.1138739163@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The problem is that for EXEC_BACKEND, which is the default for WIN32 and
> what I used for testing, progname is NULL because we do not set it after
> the fork/exec.  Most versions of printf report "(null)" for a null
> argument to printf("%s"), but our port/snprintf.c version aborts, which
> is probably better in terms of finding bugs.

Good catch.

> The attached patch fixes the problem by setting progname early in
> main(), like we do for all other applications.

It'd probably be best to strdup() argv[0], because of the likelihood
that the argv area will get clobbered at some point by ps_status.c.
It was OK to have a private static in postmaster.c, because the
postmaster doesn't ever call ps_status.c, but if we are going to expose
the variable in child processes it needs to be more globally valid.

I see that get_progname strdup's its argument in some cases but not
all --- so simplest fix is to make it always do so.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Michael FuhrDate: 2006-01-31 20:37:30
Subject: Re: BUG #2224: unlogical syntax error
Previous:From: Bruce MomjianDate: 2006-01-31 20:16:26
Subject: Re: [BUGS] BUG #2195: log_min_messages crash server when in DEBUG3 to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-01-31 21:20:55
Subject: Re: [BUGS] BUG #2195: log_min_messages crash server when in DEBUG3 to
Previous:From: Bruce MomjianDate: 2006-01-31 20:16:26
Subject: Re: [BUGS] BUG #2195: log_min_messages crash server when in DEBUG3 to

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group