From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
David Fetter <david(at)fetter(dot)org>
Cc:
Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <momjian(at)postgresql(dot)org>,
PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Date:
2010-01-27 17:27:08
Message-ID:
9027.1264613228@sss.pgh.pa.us (view raw or flat )
Thread:
2010-01-26 14:21:29 from momjian(at)postgresql(dot)org (Bruce Momjian)
2010-01-26 18:20:26 from David Fetter <david(at)fetter(dot)org>
2010-01-27 14:52:00 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-01-27 17:04:06 from David Fetter <david(at)fetter(dot)org>
2010-01-27 17:27:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-27 17:30:03 from David Fetter <david(at)fetter(dot)org>
2010-01-27 17:41:28 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-01-27 17:42:48 from David Fetter <david(at)fetter(dot)org>
2010-01-27 17:33:31 from "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
2010-01-27 21:23:12 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-02-05 14:52:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-05 19:04:22 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-05 19:09:08 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-05 19:13:11 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-02-05 19:32:13 from Bruce Momjian <bruce(at)momjian(dot)us>
Lists:
pgsql-committers pgsql-hackers
David Fetter <david(at)fetter(dot)org> writes:
> On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
>> Better write a check in the makefile.
> That assumes that everyone will always actually run the appropriate
> make before committing, which I wouldn't assume, especially for a
> "trivial" patch that's going out when someone is pressed for time.
> Checking in an unavoidable place seems much more foolproof.
The rule against tabs in SGML files is only a bit of anal retentivity
anyway. I don't think that enforcing it is worth special hacks that
we do not use anywhere else.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: David FetterDate: 2010-01-27 17:30:03
Subject : Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Previous :From : Tom LaneDate : 2010-01-27 17:08:48
Subject : Re: Add on_perl_init and proper destruction to plperl [PATCH]
pgsql-committers by date
Next :From: David FetterDate: 2010-01-27 17:30:03
Subject : Re: [COMMITTERS] pgsql: Remove tabs in SGML.
Previous :From : David FetterDate : 2010-01-27 17:04:06
Subject : Re: [COMMITTERS] pgsql: Remove tabs in SGML.