Re: WIP: Deferrable unique constraints

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)googlemail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP: Deferrable unique constraints
Date: 2009-07-20 22:41:14
Message-ID: 8e2dbb700907201541v7d49af9r8eada9289fb4c875@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/7/20 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>  Seems related to the new list in AfterTriggerSaveEvent, which is
>  used in ways that seem to conflict with its header comment ...

Reading the comment for that function, I think it is quite misleading
- mainly because the meaning of the word "event" mutates half-way
through the function. A better description might be:

/* ----------
* AfterTriggerSaveEvent()
*
* Called by ExecA[RS]...Triggers() to queue up the triggers that should
* be fired for an event.
*
* NOTE: this is called whenever there are any triggers associated with
* the event (even if they are disabled). This function decides which
* triggers actually need to be queued.
* ----------
*/

- Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2009-07-20 22:57:52 Re: COPY WITH CSV FORCE QUOTE * -- REVIEW
Previous Message Jaime Casanova 2009-07-20 22:15:12 Re: fix: plpgsql: return query and dropped columns problem