Skip site navigation (1) Skip section navigation (2)

Re: PATCH: Fail to restore table/function, if it has special characters.

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Fail to restore table/function, if it has special characters.
Date: 2010-03-18 14:19:01
Message-ID: 8cf965d31003180719w1726bda2u4713cbe69b7a4894@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi,

The bug was also there for the windows. :-(
I had to modify the commandLineCleanOption function to resolve the issue and
to make it platform-independent.

Please find the attached patch for the same.

I have made changes in the following files as described:
* include/utils/misc.h
- Changed the definition of the "commandLineCleanOption" function
* utils/misc.cpp
- Changed the "commandLineCleanOption" function to make it work on any
platform.
*/***
* * FUNCTION: commandLineCleanOption*
* * INPUTS:*
* *       option       - input string needs to be reformatted*
* *       schemaObject - Is this an object related to schema?*
* * PURPOSE:*
* *  - Fixup a (double-quoted) string for use on the command line*
* **
* *    1. Schema objects needs three (slash & double-quote) combination*
* *       instead of a double-quote to be used as a command-line option*
* *    2. Options other than the schema objects needs (slash & double-quote)
*
* *       combination instead of a double-quote to be used as a command-line
*
* *       option.*
* **
* *    i.e. CASE: Dump a table named em"p and database name tes"t having
username*
* *         xy\z. The command-line arguments for these values will be as
below:*
* **
* *         pg_dump --username "xy\\z" --table public."em\"\"\"p" "tes\"t"*
* */*
The above comments says everything about its implementation.
* frm/frmBackup.cpp
* frm/frmBackupGlobals.cpp
* frm/frmBackupServer.cpp
* frm/frmRestore.cpp

 Dave,

In order the solve this issue on 1_10_PATCHES branch, we may need to do the
similar refactoring.
Is it ok?
If yes, I can share the patch for the same.

--

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company<http://www.enterprisedb.com>

Attachment: FB14805_v2.patch
Description: application/octet-stream (8.4 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2010-03-18 14:32:29
Subject: Re: PATCH: Fail to restore table/function, if it has special characters.
Previous:From: svnDate: 2010-03-18 12:41:42
Subject: SVN Commit by dpage: r8231 - trunk/pgadmin3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group