Skip site navigation (1) Skip section navigation (2)

Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org, Dave Page <dpage(at)pgadmin(dot)org>
Subject: Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image
Date: 2009-11-19 08:33:44
Message-ID: 8cf965d30911190033je37b359i6a46ba7f4d4f8eae@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Guillaume,

On Thu, Nov 19, 2009 at 1:25 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:

> Le mardi 17 novembre 2009 à 13:35:05, Ashesh Vashi a écrit :
> > Hi All,
> >
> > After a long time, I got some time to refine/correct the patch.
> >
> > Please find the WIP patch for "Printing Support in frmQuery
> > (QueryBuilder/Graphical Query Builder(GQB)/Explain) & Save as an image".
> >
>
> It doesn't apply cleanly:
>
> guillaume(at)laptop:~/freeprojects/svn.pgadmin.org/trunk/pgadmin3.asheh$patch -
> Np0 < /home/guillaume/*.patch
> patching file pgadmin/ctl/explainPrintout.cpp
> patching file pgadmin/ctl/queryPrintout.cpp
> patching file pgadmin/ctl/module.mk
> patching file pgadmin/ctl/explainCanvas.cpp
> patching file pgadmin/pgAdmin3.cpp
> patching file pgadmin/include/ctl/explainCanvas.h
> patching file pgadmin/include/ctl/ctlSQLBox.h
> patching file pgadmin/include/frm/menu.h
> patching file pgadmin/include/frm/frmQuery.h
> patching file pgadmin/include/utils/sysSettings.h
> patching file pgadmin/include/gqb/gqbEvents.h
> patching file pgadmin/include/gqb/gqbGraphSimple.h
> patching file pgadmin/include/gqb/gqbViewController.h
> patching file pgadmin/include/gqb/gqbGraphBehavior.h
> patching file pgadmin/frm/frmQuery.cpp
> patching file pgadmin/pgAdmin3.vcproj
> Hunk #1 FAILED at 416.
> Hunk #2 FAILED at 3960.
> 2 out of 2 hunks FAILED -- saving rejects to file
> pgadmin/pgAdmin3.vcproj.rej
> patching file pgadmin/gqb/gqbView.cpp
> patching file pgadmin/gqb/gqbGraphSimple.cpp
> patching file pgadmin/gqb/module.mk
> Hunk #1 FAILED at 20.
> Hunk #2 FAILED at 28.
> 2 out of 2 hunks FAILED -- saving rejects to file pgadmin/gqb/module.mk.rej
> patching file pgadmin/gqb/gqbController.cpp
> patching file pgadmin/gqb/gqbPrintout.cpp
> patching file xtra/wx-build/build-wxgtk
>
That is because, the patch did not apply well to 'pgadmin/gqb/module.mk'
file. :(
Please find the updated patch.

>
> Anyways, I can compile it on Linux. But the compile doesn't end well:
>
> frmQuery.o: In function `frmQuery::OnPrintPreview(wxCommandEvent&)':
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2656:
> undefined reference to `ctlSQLBox::PrintPreview()'
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2658:
> undefined reference to `gqbView::PrintPreview()'
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2660:
> undefined reference to `ExplainCanvas::PrintPreview()'
> frmQuery.o: In function `frmQuery::OnPrint(wxCommandEvent&)':
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2666:
> undefined reference to `ctlSQLBox::Print()'
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2668:
> undefined reference to `gqbView::Print()'
> /home/guillaume/freeprojects/
> svn.pgadmin.org/trunk/pgadmin3.asheh/pgadmin/./frm/frmQuery.cpp:2670:
> undefined reference to `ExplainCanvas::Print()'
> collect2: ld returned 1 exit status
>
>
> There are probably a #include missing or something like this. Something
> really
> obvious. I don't have time to work on this right now because I'll begin a
> training course in a couple of minutes. I just wanted you to know about
> these
> issues.
>
>
> --
> Guillaume.
>  http://www.postgresqlfr.org
>  http://dalibo.com
>

Attachment: PrintSupport_Query_Builder_WIP_Ticket_14_v4.patch
Description: text/x-diff (97.2 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2009-11-19 20:35:07
Subject: [pgAdmin III] #93: Recording query history
Previous:From: Guillaume LelargeDate: 2009-11-19 08:03:01
Subject: Re: Fwd: [Bug 484145] [NEW] Keyboard shortcuts for closing window / application inconsistent with GNOME

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group