Re: Patch for "Panel for Joins in the Graphic Query Builder"

Oops..
Missed to attach the patch.

Regards,
Ashesh

On Tue, Dec 2, 2008 at 1:32 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:

> Hi Dave Page,
>
> Please find the updated patch.
>
> Wow - that's a whole lot more code than I was expecting (and explains
> why it took somewhat longer than I planned). What I meant, was that I
> just wanted a replacement dialogue for the existing one. What you've
>
> done is reimplement the join handling, in what I think is a *much*
> nicer way :-)
>
> Thanks
>
>
> The only issues I've seen while testing (on Windows), are:
>
> - The Join label doesn't update on the diagram if you change the join
> type unless you click on the drawing canvas afterwards.
>
> Done
> Only issue, I can see with the combobox within the Grid, is until you loose
> the focus
> (by either pressing return or moving to other cell), the value is not
> getting updated
> for that particular join
>
>
> - Selecting a join should select the corresponding row in the list.
>
> In fact, I implemented this feature on double click.
> Now onwards,
> * For single left click, row will be selected, but the "joins panel" will
> be activate.
> * For double left click, "Joins panel" will be selected and the
> corresponding row in
> the list too.
>
>
> - You are missing updates to include/images/module.mk and
> include/gqb/module.mk. The images should also be added to the VC++
> project file.
>
> Done
>
> Thanks & Regards,
> Ashesh Vashi
>

--
With Regards,
Ashesh Vashi
Software Engineer
EnterpriseDB
(www.enterprisedb.com)