Skip site navigation (1) Skip section navigation (2)

Re: Patch for "Panel for Joins in the Graphic Query Builder"

From: "Ashesh Vashi" <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: "Dave Page" <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Date: 2008-12-02 08:02:04
Message-ID: 8cf965d30812020002o5e90adf0kb8bd5aa36006c162@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Dave Page,

Please find the updated patch.

Wow - that's a whole lot more code than I was expecting (and explains
why it took somewhat longer than I planned). What I meant, was that I
just wanted a replacement dialogue for the existing one. What you've
done is reimplement the join handling, in what I think is a *much*
nicer way :-)

 Thanks


The only issues I've seen while testing (on Windows), are:

- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.

 Done
Only issue, I can see with the combobox within the Grid, is until you loose
the focus
(by either pressing return or moving to other cell), the value is not
getting updated
for that particular join


- Selecting a join should select the corresponding row in the list.

 In fact, I implemented this feature on double click.
Now onwards,
* For single left click, row will be selected, but the "joins panel" will be
activate.
* For double left click, "Joins panel" will be selected and the
corresponding row in
   the list too.


- You are missing updates to include/images/module.mk and
include/gqb/module.mk. The images should also be added to the VC++
project file.

 Done

Thanks & Regards,
Ashesh Vashi

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2008-12-02 08:08:52
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Previous:From: Dave PageDate: 2008-12-01 14:22:42
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group