Skip site navigation (1) Skip section navigation (2)

Re: BUG #2917: spi_prepare doesn't accept typename aliases

From: Jim Nasby <decibel(at)decibel(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #2917: spi_prepare doesn't accept typename aliases
Date: 2007-01-26 21:26:40
Message-ID: 8C527078-0F5A-4EF9-8411-280B2E2611D7@decibel.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Jan 26, 2007, at 9:31 AM, Tom Lane wrote:
> If you wanted to be a bit more ambitious maybe you could change the  
> fact
> that this code is throwing away typmod, which means that declarations
> like "varchar(32)" would fail to work as expected.  Perhaps it  
> should be
> fixed to save the typmods alongside the typioparams and then pass them
> to InputFunctionCall instead of passing -1.  On the other hand, we  
> don't
> currently enforce typmod for any function input or result  
> arguments, so
> maybe it's consistent that spi_prepare arguments ignore typmods too.
> Thoughts?

I'd like to see us move towards supporting that; both for function  
parameters/results as well as inside functions. It'd be nice if both  
cases got fixed at once, but IMHO fixing only one now would be better  
than fixing none.
--
Jim Nasby                                            jim(at)nasby(dot)net
EnterpriseDB      http://enterprisedb.com      512.569.9461 (cell)



In response to

Responses

pgsql-hackers by date

Next:From: Jim NasbyDate: 2007-01-26 21:39:35
Subject: Re: Proposal: Change of pg_trigger.tg_enabled and adding
Previous:From: Tom LaneDate: 2007-01-26 21:18:44
Subject: Re: pg_restore exclude schema from being droped option

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group