Skip site navigation (1) Skip section navigation (2)

Re: Bug with view definitions?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Justin Clift <jc(at)telstra(dot)net>,PostgreSQL Hackers Mailing List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug with view definitions?
Date: 2004-07-02 03:40:03
Message-ID: 8981.1088739603@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> Hmm, is this wrong on line 2085 of src/backend/adt/utils/ruleutils.c:

>   need_paren = (PRETTY_PAREN(context) ?
>                                 !IsA(op->rarg, RangeTblRef) : true);

In a quick glance this code seems close to completely brain dead :-(
For one thing, why isn't it making separate determinations about whether
the left and right inputs of the UNION (resp INTERSECT or EXCEPT)
operator need to be parenthesized?  After that maybe we could figure out
what the individual decisions need to be.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Joshua D. DrakeDate: 2004-07-02 03:45:51
Subject: Re: compile errors in new PL/Pler
Previous:From: Christopher Kings-LynneDate: 2004-07-02 03:36:34
Subject: Re: Bug with view definitions?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group