Jacob Rief <jacob(dot)rief(at)gmx(dot)at> writes:
> The Apache runtime library, which is using a similar concept for
> allocating heap-based memory out of a pool, has some since utility
> functions, named apr_psprintf and apr_pstrdup.
SPI_palloc might possibly be worth the trouble, but the other thing
is duplicative of the StringInfo routines, and I do not think it's
a good idea to provide duplicate ways to accomplish the same thing.
It's just more code to maintain and more things for newcomers to
learn about when trying to read someone else's code.
Also, proposed API additions without any documentation are not acceptable.
The docs addition for SPI_palloc would be substantially larger than the
code itself; is it worth the trouble?
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Zeugswetter Andreas ADI SD||Date: 2007-04-25 08:00:16|
|Subject: Re: [HACKERS] Full page writes improvement, code update|
|Previous:||From: Peter Eisentraut||Date: 2007-04-24 21:08:57|
|Subject: Re: SPI_psprintf and SPI_pstrdup|