Skip site navigation (1) Skip section navigation (2)

Re: pgadminIII on OSX 10.3.9; w/ wxWidgets-2.6.0

From: OpenMacNews <OpenMacNews(at)speakeasy(dot)net>
To: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgadminIII on OSX 10.3.9; w/ wxWidgets-2.6.0
Date: 2005-04-26 17:37:40
Message-ID: 891A70C4FEF768DDFC195356@tiedgar (view raw or flat)
Thread:
Lists: pgadmin-hackers
hi,

> Hm.. I have no idea what going on here... Is there an autoconf guru here
> who might provide insight?
>
>> hmmm ... why/where is "pg_debug_build=no" NOT being set ...
>> do we need an EXPLICIT test for "--disable-debug" to set the NO case?
>>
>> i'm gonna try this without the --disable-debug flag ...
> I just checked - the nightly builds are done with neither "--enable-debug"
> nor "--disable-debug" specified, and things work correctly...

well, i just rebuilt w/ NO debug flag in the config, i.e.:

    ./configure \
    --enable-appbundle \
    --enable-static \
    --with-wx=/usr/local/wxWidgets-260 \
    --with-wx-config=wx-config \
    --with-pgsql=/usr/local/pgsql \
    --with-pgsql-include=/usr/local/pgsql/include

NOW, the 'make install' output shows:

    ...
    make  install-exec-hook
    cd /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS ;\
    mv pgadmin3 tmp ;\
    mv tmp pgAdmin3 ;\
        echo no ;\
    if test "no" = "no"; then \
            strip pgAdmin3 ;\
    fi
    no
    ...

AND the executable IS properly stripped:

    % ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
        -rwxr-xr-x  1 root admin 7767372 Apr 26 10:18
        /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

so, what we're seeing is:

    "./configure --disable-debug", fails to set pg_debug_build=no, i.e. sets = 
yes.

but,

    "./configure" sets it correctly

> FYI, configure is autogenerated, and the snipped that checks
> for the debug option is found in acinclude.m4 - but it looks
> even more correct there (at least for my autoconf-unsavy eyes...)

looking in acinclude.m4:

    ###########################
    # Debug build of pgAdmin3 #
    ###########################
    AC_DEFUN([ENABLE_DEBUG],
    [AC_ARG_ENABLE(debug,
    [ --enable-debug       build a debug version of pgAdmin3],
    [pg_debug_build=yes
    CFLAGS="-Wall -g -O0"
    CXXFLAGS="-Wall -g -O0"],
    [pg_debug_build=no])
    ])
    AC_SUBST(pg_debug_build)

looks ok to me as well ...

ok, this has got to be something obvious/simple, but i'm missing it.

richard

In response to

pgadmin-hackers by date

Next:From: cvsDate: 2005-04-26 19:31:40
Subject: CVS Commit by dpage: New Directory
Previous:From: Florian G. PflugDate: 2005-04-26 17:03:47
Subject: Re: pgadminIII on OSX 10.3.9; w/ wxWidgets-2.6.0

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group