Re: clean up assertion code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: nconway(at)klamath(dot)dyndns(dot)org (Neil Conway)
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: clean up assertion code
Date: 2002-07-29 20:01:07
Message-ID: 8825.1027972867@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

nconway(at)klamath(dot)dyndns(dot)org (Neil Conway) writes:
> This patch removes a lot of unused code related to assertions and
> error handling, and simplifies the code that remains. Apparently,
> the code that left Berkeley had a whole "error handling subsystem",
> which exceptions and whatnot. Since we don't use that anymore,
> there's no reason to keep it around.

While I don't have a problem with this idea, the patch is poorly
presented: if applied as-is, it will reduce the no-longer-needed files
to zero lines, rather than deleting them as intended.

When you want a patch to add or remove files, please list the added
or removed files separately, rather than presenting it like this.
It's much too easy for the committer to miss the need for "cvs add"
and "cvs remove" commands otherwise.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2002-07-29 20:08:52 Re: clean up assertion code
Previous Message Neil Conway 2002-07-29 19:35:25 clean up assertion code