Skip site navigation (1) Skip section navigation (2)

Re: pg_dump --pretty-print-views

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: David Fetter <david(at)fetter(dot)org>, Marko Tiikkaja <pgmail(at)joh(dot)to>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump --pretty-print-views
Date: 2013-01-10 17:35:00
Message-ID: 8821.1357839300@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I think there's a very good case for breaking the nexus between 
> PRETTYFLAG_PAREN and PRETTYFLAG_INDENT+line wrapping for views. Only 
> PRETTYFLAG_PAREN affects the safety issue. The others are just about 
> white space in safe places.

What I was actually thinking about was turning on indent/linewrapping
all the time (ie, no change on pg_dump's side, just hack ruleutils).
If we believe it's safe, why not just do it?  It's the paren-removal
that pg_dump can't tolerate.

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2013-01-10 17:37:07
Subject: Re: pg_dump --pretty-print-views
Previous:From: Andrew DunstanDate: 2013-01-10 17:31:07
Subject: Re: pg_dump --pretty-print-views

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group