Skip site navigation (1) Skip section navigation (2)

Re: Verbosity of Function Return Type Checks

From: Volkan YAZICI <yazicivo(at)ttmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Verbosity of Function Return Type Checks
Date: 2008-08-09 10:13:03
Message-ID: 87skte339s.fsf@alamut.mobiliz.com.tr (view raw or flat)
Thread:
Lists: pgsql-hackers
[Please ignore the previous reply.]

On Fri, 8 Aug 2008, Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I think this is a good idea, but the new error messages need more work.
> Have a look at the message style guidelines please,
> http://www.postgresql.org/docs/8.3/static/error-style-guide.html

Right. Done -- I hope.

> Particularly I think you need to keep the original errmsg() and add the
> new messages as errdetail().

Made callers pass related error message as a string parameter, and
appended required details using errdetail().

> (I notice that there's the slight problem
> that the error messages are different for the different callers.)

Above mentioned change should have addressed this issue too.

> Also, please use context diffs.

Done.


Regards.


Attachment: plpgsql_validate_tupdesc_compat.diff
Description: text/x-diff (5.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Abhijit Menon-SenDate: 2008-08-09 10:27:42
Subject: which statements need bind/describe messages?
Previous:From: Volkan YAZICIDate: 2008-08-09 09:54:12
Subject: Re: Verbosity of Function Return Type Checks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group