Skip site navigation (1) Skip section navigation (2)

Re: Preliminary patch for tsearch example dictionaries/parsers in contrib

From: karpov(at)sao(dot)ru (Sergey V(dot) Karpov)
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgreSQL(dot)org, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
Subject: Re: Preliminary patch for tsearch example dictionaries/parsers in contrib
Date: 2007-10-09 14:32:02
Message-ID: 87r6k41hr1.fsf@tigris.sai.msu.ru (view raw or flat)
Thread:
Lists: pgsql-patches
Magnus Hagander <magnus(at)hagander(dot)net> writes:

>> > * Allowing config files to be read from anywhere is not acceptable.
>> > We have dealt with this in the core code and the contrib examples
>> > *must* follow the same rules.
>> 
>> Is it necessary to require this behaviour from each contrib module? They
>> are not core code, and usually solve application-level tasks - is it
>> optimal to store the application config files in postgres tree?
>
> Yes. We've been thruogh that many times wrt adminpack, and we don't want to
> do that again :-)
> See convert_and_check_filename() in adminpack.c.

Ok, I understand.

In this case, the simplest way for me is to use
get_tsearch_config_filename(), which assumes files in
share/tsearch_data/, like standard tsearch dictionaries do. Or contrib
modules have to keep their files strictly in share/contrib/?

Sergey Karpov

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-10-09 15:04:49
Subject: Re: libpq crash fix [was: Provide a way to not ask for a password in psql]
Previous:From: Martin PittDate: 2007-10-09 13:56:33
Subject: Provide a way to not ask for a password in psql

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group