From: | Neil Conway <neilc(at)samurai(dot)com> |
---|---|
To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | minor smgr code cleanup |
Date: | 2004-01-05 21:44:23 |
Message-ID: | 87ptdynk94.fsf@mailbox.samurai.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
This patch cleans up some code in the smgr and elsewhere:
- Update comment in IsReservedName() to the present day, remove
"ugly coding for speed" as this is no longer a performance
critical function
- Improve some variable & function names in commands/vacuum.c. I
was planning to rewrite this to avoid lappend(), but since I
still intend to do the list rewrite, there's no need for that.
- Update some smgr comments which seemed to imply that we still
forced all dirty pages to disk at commit-time.
- Replace some #ifdef DIAGNOSTIC code with assertions.
- Make the distinction between OS-level file descriptors and
virtual file descriptors a little clearer in a few comments
- Other minor comment improvements in the smgr code
Unless anyone objects, I intend to apply this code in about 48 hours.
-Neil
Attachment | Content-Type | Size |
---|---|---|
smgr-code-cleanup-1.patch | text/x-patch | 21.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2004-01-05 21:45:09 | logging statement levels |
Previous Message | Neil Conway | 2004-01-05 21:31:40 | remove obsolete NULL casts |