fix oid casting inconsistency

From: Neil Conway <neilc(at)samurai(dot)com>
To: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: fix oid casting inconsistency
Date: 2004-02-17 03:00:49
Message-ID: 87ptceif4u.fsf@mailbox.samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This patch fixes a minor error message inconsistency. When rejecting
input to the oid type, the following error message is emitted:

nconway=# select 'd'::oid;
ERROR: invalid input syntax for type "oid": "d"

This patch removes the quotes from "oid", to make this error message
consistent with the error messages for rejected input to most other
types.

While I suppose it's possible that some applications might be
examining this error message string, (a) this particular error message
isn't very likely be used for that (b) we have error codes now.

I also took the liberty of removing some long-unused code from
src/backend/utils/adt/numutils.c

Unless anyone objects, I'll apply this within 24 hours.

-Neil

Attachment Content-Type Size
adt-misc-cleanup-2.patch text/x-patch 10.7 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-02-17 03:16:01 Re: [HACKERS] dollar quoting
Previous Message Tom Lane 2004-02-17 02:54:52 Re: [PATCHES] dollar quoting