Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Date: 2007-06-26 15:45:51
Message-ID: 87myymhg7k.fsf@oxford.xeocode.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Yeah.  I'm disinclined to pre-emptively quote things for pie-in-the-sky
> patches.  WITH is already a grammar keyword, so it's not a big deal to
> tweak things to quote it, but adding a dozen keywords that have zero
> functionality in the grammar is another thing entirely.

Sure.

> Also, the fact that this particular form of the grammar requires
> reserving the keywords does not prove that there is no way to have the
> features without that.  I'd want to see us try a little harder first.

At least some of them are unavoidable conflicts:

select a,b,count(*) from tab GROUP BY cube(a,b)
select a,b,count(*) from tab GROUP BY rollup(a,b)

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-06-26 15:59:49
Subject: Re: [PATCHES] New Zealand - TZ change
Previous:From: Andrew DunstanDate: 2007-06-26 15:31:31
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

pgsql-committers by date

Next:From: Tom LaneDate: 2007-06-26 16:11:28
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords
Previous:From: Andrew DunstanDate: 2007-06-26 15:31:31
Subject: Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group