A few quick comments:
- don't use C++-style comments
- please update the documentation
- update the comment at the top of copy.c
Bill Moran <wmoran(at)potentialtech(dot)com> writes:
> Ideally, this should cover all cases of old and new syntax, except
> where "AS" is present.
ISTM it would be easy to allow for an optional 'AS' token following
the 'DELIMITER[S]' token.
> The only drawback I can see is that \copy is now more liberal in
> what it accepts, and may accept incomplete statements without
> issuing an error (i.e. a WITH or USING clause at the end of a \copy
> statement will simply be ignored, and no error generated)
Why can't you check for this?
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2004-01-20 23:50:03|
|Subject: Re: Current-stream read for psql's \copy |
|Previous:||From: Neil Conway||Date: 2004-01-20 23:17:32|
|Subject: Re: Patch for search_path --- apply to 7.4 branch?|