Hm, I assume we want to be able to turn on and off plugins in a running
session? I think the "free_using_plugin" flag:
! if (get_relation_stats_hook)
! vardata->statsTuple = (*get_relation_stats_hook)
! if (vardata->statsTuple)
! vardata->free_using_plugin = true;
! vardata->statsTuple = SearchSysCache(STATRELATT,
is insufficient to handle this. vardata->free_using_plugin could be true but
by the time the variable is released the plugin pointer could have been
cleared. Or worse, set to a different plugin.
The easiest way to fix this seems like also the best way, instead of storing a
boolean store the pointer to the release function.
Ask me about EnterpriseDB's 24x7 Postgres support!
In response to
pgsql-hackers by date
|Next:||From: Heikki Linnakangas||Date: 2008-09-22 17:43:16|
|Subject: FSM, now without WAL-logging|
|Previous:||From: David E. Wheeler||Date: 2008-09-22 17:13:09|
|Subject: Re: Where to Host Project|
pgsql-patches by date
|Next:||From: Simon Riggs||Date: 2008-09-22 18:19:02|
|Subject: Re: get_relation_stats_hook()|
|Previous:||From: Ryan Bradetich||Date: 2008-09-22 05:30:34|
|Subject: Re: [PgFoundry] Unsigned Data Types [1 of 2]|