Packed varlena tuptoaster.c oops

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: PostgreSQL-development Hackers <pgsql-patches(at)postgresql(dot)org>
Subject: Packed varlena tuptoaster.c oops
Date: 2007-10-11 14:51:22
Message-ID: 87abqpyaad.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Caught this in my testing with enhanced debugging checks.

Index: src/backend/access/heap/tuptoaster.c
===================================================================
RCS file: /home/stark/src/REPOSITORY/pgsql/src/backend/access/heap/tuptoaster.c,v
retrieving revision 1.77
diff -u -r1.77 tuptoaster.c
--- src/backend/access/heap/tuptoaster.c 1 Oct 2007 16:25:56 -0000 1.77
+++ src/backend/access/heap/tuptoaster.c 11 Oct 2007 14:47:17 -0000
@@ -813,7 +813,6 @@
pfree(DatumGetPointer(old_value));

toast_free[i] = true;
- toast_sizes[i] = VARSIZE(toast_values[i]);

need_change = true;
need_free = true;

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2007-10-11 16:11:28 Re: [HACKERS] quote_literal with NULL
Previous Message Marko Kreen 2007-10-11 14:48:35 Patch: txid in core