Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add a note about another issue that needs to be considered before

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-hackers(at)postgresql(dot)org>, <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add a note about another issue that needs to be considered before
Date: 2007-11-05 16:22:53
Message-ID: 87abps64rm.fsf@oxford.xeocode.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>> FWIW I found another issue with this variable when I was experimenting with
>> small block sizes. If you set the target <= the tuple header the toaster
>> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
>> think the right solution is just to change it to use plain int32 arithmetic
>> everywhere.
>
> Somehow I can't get excited about that.  If we ever do open things up to
> allow user control of the target, we'd certainly constrain it to a sane
> range.

Yeah, i didn't even mention it at the time. I just thought I would mention it
now since you were adding comments on restrictions to the toast threshold. 

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's Slony Replication support!

In response to

pgsql-hackers by date

Next:From: Martijn van OosterhoutDate: 2007-11-05 16:48:04
Subject: Re: Fwd: Clarification about HOT
Previous:From: Gokulakannan SomasundaramDate: 2007-11-05 16:13:07
Subject: Re: Visibility map thoughts

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-11-05 16:30:42
Subject: Re: pgsql: Document txid functions.
Previous:From: Tom LaneDate: 2007-11-05 16:21:05
Subject: Re: pgsql: Document txid functions.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group