Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV
Date: 2003-08-04 18:43:23
Message-ID: 8786.1060022603@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Joe Conway <mail(at)joeconway(dot)com> writes:
> This patch includes pltcl and plpython, with the mentioned style issue 
> fixed. Both PLs pass their scripted tests and my simple statement level 
> trigger test.

Applied, thanks.

BTW, one other stylistic nit: I don't think comments like

		/* internal error */
		elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event);

are really necessary.  In the brave new ereport world, any elog(ERROR)
call is an internal error by definition --- if it isn't, you should be
using ereport.  So the use of elog is sufficient documentation.  IMHO
anyway.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: scott.marloweDate: 2003-08-04 19:12:31
Subject: Re: Thread-safe configuration option appears to
Previous:From: Larry RosenmanDate: 2003-08-04 18:07:51
Subject: Re: Thread-safe configuration option appears to

pgsql-patches by date

Next:From: Joe ConwayDate: 2003-08-04 19:46:43
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython
Previous:From: Anne DudfieldDate: 2003-08-04 18:40:35
Subject: Patch for select() -> poll() in libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group