Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] statement level trigger causes pltcl, plpython SIGSEGV
Date: 2003-08-04 18:43:23
Message-ID: 8786.1060022603@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway <mail(at)joeconway(dot)com> writes:
> This patch includes pltcl and plpython, with the mentioned style issue
> fixed. Both PLs pass their scripted tests and my simple statement level
> trigger test.

Applied, thanks.

BTW, one other stylistic nit: I don't think comments like

/* internal error */
elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event);

are really necessary. In the brave new ereport world, any elog(ERROR)
call is an internal error by definition --- if it isn't, you should be
using ereport. So the use of elog is sufficient documentation. IMHO
anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message scott.marlowe 2003-08-04 19:12:31 Re: Thread-safe configuration option appears to
Previous Message Larry Rosenman 2003-08-04 18:07:51 Re: Thread-safe configuration option appears to

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2003-08-04 19:46:43 Re: [HACKERS] statement level trigger causes pltcl, plpython
Previous Message Anne Dudfield 2003-08-04 18:40:35 Patch for select() -> poll() in libpq