Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Parenthesize macro arguments safely.

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)postgresql(dot)org>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Parenthesize macro arguments safely.
Date: 2007-09-26 17:26:49
Message-ID: 877imdbana.fsf@oxford.xeocode.com (view raw or flat)
Thread:
Lists: pgsql-committers
"Tom Lane" <tgl(at)postgresql(dot)org> writes:

> Log Message:
> -----------
> Parenthesize macro arguments safely.  I see no bug among the current
> uses of PG_DETOAST_DATUM_SLICE, but it's clearly trouble waiting to
> happen.

If this is trouble waiting to happen it should probably be backported.
Otherwise a future bug fix could introduce a call to it and then be
backportted fix without anyone catching that the macro was defined
differently previously.

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

In response to

pgsql-committers by date

Next:From: Tom LaneDate: 2007-09-26 18:51:51
Subject: pgsql: Create a function variable "join_search_hook" to let plugins
Previous:From: Magnus HaganderDate: 2007-09-26 11:19:09
Subject: pgsql: Properly pass -c parameter to ecpg when building regression

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group