Re: pgsql: Re-enable the old code in xlog.c that tried to use

tgl(at)postgresql(dot)org (Tom Lane) writes:

> Log Message:
> -----------
> Re-enable the old code in xlog.c that tried to use posix_fadvise(), so that
> we can get some buildfarm feedback about whether that function is still
> problematic. (Note that the planned async-preread patch will not really
> prove anything one way or the other in buildfarm testing, since it will
> be inactive with default GUC settings.)

! #if defined(USE_POSIX_FADVISE) && defined(POSIX_FADV_DONTNEED)

I think if we're not putting the AC_CHECK_RUN check in then this should just
be HAVE_POSIX_FADVISE not USE_POSIX_FADVISE. The latter was the define I made
if the run check passed.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training!