Skip site navigation (1) Skip section navigation (2)

Re: Patch to psql to allow SEARCH_PATH to be set from env

From: Neil Conway <neilc(at)samurai(dot)com>
To: Scott Goodwin <scott(at)scottg(dot)net>
Cc: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>,pgsql-patches(at)postgresql(dot)org
Subject: Re: Patch to psql to allow SEARCH_PATH to be set from env
Date: 2004-02-10 20:24:07
Message-ID: 8765eewumw.fsf@mailbox.samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Scott Goodwin <scott(at)scottg(dot)net> writes:
> If anyone cares to, I'd still like feedback on anything I could have
> done better in this patch

Since, you asked, two minor points: (1) palloc() is for memory
allocation in the backend; use malloc() (or a wrapper like
pg_malloc()) in frontend apps and libpq (2) naming variables like
word1_Word2 is inconsistent with the surrounding code.

-Neil


In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2004-02-10 20:27:31
Subject: Re: Patch to psql to allow SEARCH_PATH to be set from env
Previous:From: Andrew SullivanDate: 2004-02-10 18:57:14
Subject: Re: [PATCHES] Current-stream read for psql's \copy

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group