Skip site navigation (1) Skip section navigation (2)

Re: support for printing/exporting xml

From: Neil Conway <neilc(at)samurai(dot)com>
To: Brian Moore <brianmooreca(at)yahoo(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: support for printing/exporting xml
Date: 2004-01-29 11:11:54
Message-ID: 873c9zggat.fsf@mailbox.samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Brian Moore <brianmooreca(at)yahoo(dot)com> writes:
> please find attached my support for printing/exporting
> xml from postgresql.

A few quick comments:

- why is it necessary to include an entire hash table implementation?
  Why does this code require a hash table to begin with, considering
  the relatively small size of pg_type? ISTM something far simpler
  (for example, a dynamically allocated sorted array and a binary
  search) would be sufficient.

- testing code doesn't belong in libpq

- you'll need to update the libpq docs

- you should follow the libpq API naming convention: the function
  should be look like some variant of PQresultAsXML()

- context diffs are the preferred format

-Neil


In response to

Responses

pgsql-patches by date

Next:From: Mark Cave-AylandDate: 2004-01-29 12:06:22
Subject: Re: ANALYZE patch for review
Previous:From: Joe ConwayDate: 2004-01-29 00:55:17
Subject: Re: [GENERAL] SELECT Question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group