Skip site navigation (1) Skip section navigation (2)

Re: msvc const warnings

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: msvc const warnings
Date: 2007-07-24 13:57:37
Message-ID: 871wex3nvy.fsf@oxford.xeocode.com (view raw or flat)
Thread:
Lists: pgsql-patches
"Magnus Hagander" <magnus(at)hagander(dot)net> writes:

> Stefan mentioned that the warning may be one that shows up in a different
> compiler somewhere as well, thouh, which might indicate that we should fix
> the underlying issue? (Even if the code is correct, if it confuses multiple
> compilers...)

I think the right fix is just to remove the const qualifier. It's clearly not
treating the pointer as const if it's passing it to pfree which is surely a
state change if anything is.

We do far too much casting to (void*) as it is and I would dearly love to go
through the whole source tree and remove all the redundant casts. All they do
is cover up real type clash bugs.

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com


In response to

Responses

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-07-24 13:59:15
Subject: Re: plperl warnings on win32
Previous:From: Tom LaneDate: 2007-07-24 13:55:57
Subject: Re: plperl warnings on win32

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group