Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "PostgreSQL-development Hackers" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch
Date: 2007-07-27 17:17:21
Message-ID: 871wetpxzy.fsf@oxford.xeocode.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Sorry, meant to send the previous message to pgsql-patches.

Here's a version cut using cvs diff so it's usable with -p0

I added one more fixup. There was a silly test in toast_fetch_datum_slice()
which handled compressed datums. Returning a slice of a compressed datum is
nonsensical with toast since the resulting datum would be useless. I also
added an assertion in this function that the datum is external before we treat
it as a toast_pointer.

(Incidentally, I did eventually manage to construct a case to reach all the pfrees.)


Attachment: tuptoaster-fixup.patch.gz
Description: application/octet-stream (1.5 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Stephen FrostDate: 2007-07-27 18:09:52
Subject: Re: [PATCHES] allow CSV quote in NULL
Previous:From: Andrew DunstanDate: 2007-07-27 16:03:19
Subject: Re: [PATCHES] allow CSV quote in NULL

pgsql-patches by date

Next:From: Stephen FrostDate: 2007-07-27 18:09:52
Subject: Re: [PATCHES] allow CSV quote in NULL
Previous:From: Erwin BrandstetterDate: 2007-07-27 16:17:19
Subject: Obsolete bits in docs for SQL-GRANT

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group