| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Double Backslash example patch |
| Date: | 2003-12-17 18:07:35 |
| Message-ID: | 8692.1071684455@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I see that psql/mainloop.c contains this comment:
> * FIXME: rewrite this whole thing with flex
> Is now the time to do that?
If you feel like giving it a shot, ain't nobody gonna stand in your way.
MainLoop() is well past the level of unmaintainability IMHO (which is
why I'd not tried to touch it in the original quick patch).
I'm not totally convinced that flex can do the job, but in any case a
ground-up redesign for legibility might be the only cure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2003-12-17 18:49:31 | Re: [PATCHES] Double Backslash example patch |
| Previous Message | Bruce Momjian | 2003-12-17 17:51:24 | Re: [HACKERS] pg_service.conf ignores dbname parameter |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-12-17 18:45:52 | Re: restore error - language "plperlu" is not trusted |
| Previous Message | Christopher Murtagh | 2003-12-17 17:31:38 | Re: restore error - language "plperlu" is not trusted |