| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> |
| Cc: | "Patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Geometry patch for freebsd alpha |
| Date: | 2001-12-20 15:35:13 |
| Message-ID: | 8669.1008862513@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> *** src/test/regress/resultmap 2001/12/19 17:25:55 1.52
> --- src/test/regress/resultmap 2001/12/20 02:45:56
> ***************
> *** 13,19 ****
> geometry/.*-bsdi=geometry-bsdi-precision
> geometry/.*-darwin=geometry-powerpc-darwin
> geometry/.*-freebsd=geometry-positive-zeros
> ! geometry/.*-freebsd4=geometry-positive-zeros-bsd
> geometry/i386-.*-openbsd=geometry-positive-zeros-bsd
> geometry/sparc-.*-openbsd=geometry-positive-zeros
> geometry/.*-irix6=geometry-irix
> --- 13,20 ----
> geometry/.*-bsdi=geometry-bsdi-precision
> geometry/.*-darwin=geometry-powerpc-darwin
> geometry/.*-freebsd=geometry-positive-zeros
> ! geometry/i.86-.*-freebsd4=geometry-positive-zeros-bsd
> ! geometry/alpha-.*-freebsd4=geometry-positive-zeros
> geometry/i386-.*-openbsd=geometry-positive-zeros-bsd
> geometry/sparc-.*-openbsd=geometry-positive-zeros
> geometry/.*-irix6=geometry-irix
Hmm. I think it's bad practice to have two lines in resultmap that
can match, and here "geometry/.*-freebsd" will certainly match all the
same platforms that your two lines do. My inclination is to replace
all three lines with
geometry/i.86-.*-freebsd=geometry-positive-zeros-bsd
geometry/alpha-.*-freebsd=geometry-positive-zeros
and wait to see if anyone using version 3 complains.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Karel Zak | 2001-12-20 18:31:30 | Czech NLS |
| Previous Message | Thomas Lockhart | 2001-12-20 05:17:18 | Re: SunOS patch for memcmp() |