Skip site navigation (1) Skip section navigation (2)

Re: Optimizing GetRunningTransactionLocks()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Optimizing GetRunningTransactionLocks()
Date: 2011-10-31 20:43:18
Message-ID: 8583.1320093798@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> My list of things to do included optimising
> GetRunningTransactionLocks(), run once per checkpoint.

> I was thinking I needed to try harder to avoid acquiring LWlocks on
> all the lock partitions.

> ISTM that I don't need to do this - lwlocks on lock partitions are
> almost never contended now, so this should go much faster than before.

> Any thoughts? Do we think it would benefit from further tweaking?

> I'll assume not unless I hear from somebody with a different idea.

ISTM that some evidence of a problem should be acquired before expending
sweat on a solution ... have you seen evidence that this creates any
real issue?

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Scott MeadDate: 2011-10-31 21:37:33
Subject: IDLE in transaction introspection
Previous:From: Tom LaneDate: 2011-10-31 20:22:45
Subject: Re: myProcLocks initialization

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group