Skip site navigation (1) Skip section navigation (2)

RE: ODBC Patch

From: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
To: "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: RE: ODBC Patch
Date: 2001-02-12 17:10:16
Message-ID: 8568FC767B4AD311AC33006097BCD3D61A2989@woody.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgsql-patches

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: 12 February 2001 14:12
> To: Dave Page
> Cc: 'pgsql-patches(at)postgresql(dot)org'
> Subject: Re: [PATCHES] ODBC Patch
> 
> 
> > > Dave, can you test the attached patch?  I assume the 
> problem was that
> > > pgindent does not recognize // as comments, and in fact, 
> we don't want
> > > to use them.
> > > 
> > > This should fix the problem.
> > 
> > I've not tested it (I'm just configuring my new laptop :-) 
> ) but that should
> > work (and has done - if you look back in CVS I made that 
> mod before). The
> > problem is that MS VC++ autogenerates resource.h whenever 
> psqlodbc.rc is
> > updated in the IDE. Is it possible to get pgindent to 
> ignore that file or
> > would that cause more problems? 
> 
> Sure, we can ignore it, but do we want an MS-generated file to be
> tracked in our CVS, and especially one with // comments?
> 
> If resource.h was included only by MS compilers, that would be better,
> but I see every platform including the file.
> 
> Can you send me that resource.h file again, and I will merge in any
> change made by *.rc, but keep the /* */ comments, OK?

Here's the (working) file with C style comments.

I've made comments on the subject in a reply to Tom's message...

Regards, Dave.


Attachment: resource.h
Description: application/octet-stream (2.3 KB)

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-02-12 17:53:51
Subject: Re: ODBC Patch
Previous:From: Dave PageDate: 2001-02-12 17:03:40
Subject: RE: ODBC Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group