Skip site navigation (1) Skip section navigation (2)

RE: ODBC Patch

From: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "'pgsql-patches(at)postgresql(dot)org'" <pgsql-patches(at)postgresql(dot)org>
Subject: RE: ODBC Patch
Date: 2001-02-12 17:03:40
Message-ID: 8568FC767B4AD311AC33006097BCD3D61A2988@woody.vale-housing.co.uk (view raw or flat)
Thread:
Lists: pgsql-patches

> -----Original Message-----
> From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> Sent: 12 February 2001 15:19
> To: Bruce Momjian
> Cc: Dave Page; 'pgsql-patches(at)postgresql(dot)org'
> Subject: Re: [PATCHES] ODBC Patch 
> 
> 
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> problem is that MS VC++ autogenerates resource.h whenever 
> psqlodbc.rc is
> >> updated in the IDE. Is it possible to get pgindent to 
> ignore that file or
> >> would that cause more problems? 
> 
> > Sure, we can ignore it, but do we want an MS-generated file to be
> > tracked in our CVS, and especially one with // comments?
> > If resource.h was included only by MS compilers, that would 
> be better,
> > but I see every platform including the file.
> 
> Good point.  This will not be buildable on machines whose compilers do
> not like //.
> 
> > Can you send me that resource.h file again, and I will merge in any
> > change made by *.rc, but keep the /* */ comments, OK?
> 
> I don't think that's a feasible long-term maintenance approach either.
> Will you or Dave remember to do this any time psqlodbc.rc changes?

I can certainly do this anytime I update the driver, but I obviously can't
keep track of other people who change it. IMHO it (psqlodbc.rc) should be
updated for every patch submitted as it (along with psqlodbc.h) contain the
revision number which is essential for the ODBC driver which is often
updated outside of the main PostgreSQL releases.

> Seems like the correct answer is for pgindent to 
> automatically transform
> "// comment" to "/* comment */".

This sounds much more sensible.

Regards,

Dave.

Responses

pgsql-patches by date

Next:From: Dave PageDate: 2001-02-12 17:10:16
Subject: RE: ODBC Patch
Previous:From: andrea gelminiDate: 2001-02-12 15:22:10
Subject: Re: oid2name silly patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group