Re: PL/TCL Patch to prevent postgres from becoming multithreaded

From: "Marshall, Steve" <smarshall(at)wsi(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: PL/TCL Patch to prevent postgres from becoming multithreaded
Date: 2007-09-21 11:55:24
Message-ID: 8536F69C1FCC294B859D07B179F069440A789512@EXCHANGE.ad.wsicorp.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

I'm glad to see the patch making its way through the process. I'm also
glad you guys do comprehensive testing before accepting it, since we are
only able to test in a more limited range of environments.

We have applied the patch to our 8.2.4 installations and are running it
in a high transaction rate system (processing lots and lots of
continually changing weather data). Let me know if there is any
information we could provide that would be of help in making the
back-patching decision.

Yours,
Steve Marshall

-----Original Message-----
From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
Sent: Thursday, September 20, 2007 8:33 PM
To: Marshall, Steve
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming
multithreaded

"Marshall, Steve" <smarshall(at)wsi(dot)com> writes:
> There is a problem in PL/TCL that can cause the postgres backend to
> become multithreaded. Postgres is not designed to be multithreaded,
so
> this causes downstream errors in signal handling. We have seen this
> cause a number of "unexpected state" errors associated with
> notification handling; however, unpredictable signal handling would be

> likely to cause other errors as well.

I've applied this patch to CVS HEAD (8.3-to-be). I'm a bit hesitant to
back-patch it however, at least not till it gets through some beta
testing.

Thanks for the detailed explanation, test case, and patch!

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message blay bloo 2007-09-21 13:59:58 Schema access in PL/PGSQL for custom objects - i.e. type access?
Previous Message Heikki Linnakangas 2007-09-21 11:54:35 Re: HOT is applied

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-09-21 15:28:29 Minor comment fixes
Previous Message ITAGAKI Takahiro 2007-09-21 11:25:02 Re: ecpg PREPARE is not thread safe