| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Josh Wilmes <jwilmes(at)cisco(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, Nick Johnson <njohnson(at)cisco(dot)com> |
| Subject: | Re: ISM shared memory on solaris |
| Date: | 2003-10-27 18:14:44 |
| Message-ID: | 853.1067278484@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> ! #if defined(sun) && defined(__sparc__)
> /* use intimate shared memory on SPARC Solaris */
> memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
> #else
I think this is going in the wrong direction. Why isn't the code just
#if defined(SHM_SHARE_MMU)
/* use intimate shared memory on Solaris */
memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
#else
If the symbol is available I think we probably want to use it. It is an
O/S issue, not a hardware issue, and so the test on __sparc__ seems
quite wrongheaded ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-10-27 18:30:14 | Re: ISM shared memory on solaris |
| Previous Message | Tom Lane | 2003-10-27 17:14:05 | Re: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-10-27 18:30:14 | Re: ISM shared memory on solaris |
| Previous Message | Tom Lane | 2003-10-27 18:10:45 | Re: Timestamp docs weirdness |