Re: pgsql: Do not try to change a const variable.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Do not try to change a const variable.
Date: 2008-12-15 19:09:07
Message-ID: 8494.1229368147@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> I get this

> misc.c:253: warning: assignment discards qualifiers from pointer target
> type

> I'm guessing that error comes from this commit?

Yeah. It's got worse problems than that too: it's not accounting for
possibility that internationalized string is significantly longer than
the ASCII version. Fixed, I think.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-12-15 21:11:54 pgsql: Add missing 'break' in Win32 switch statement, reported by Martin
Previous Message Tom Lane 2008-12-15 19:07:48 pgsql: Fix cast-away-const problem as well as bogus calculation of