Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.
Date: 2006-09-03 03:22:35
Message-ID: 8417.1157253755@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Bruce Momjian <bruce(at)momjian(dot)us> writes:
>> This patch has broken half the buildfarm, and I've still not seen a
>> rationale why we need to make such a change at all.

> Fixed with attached patch.  The use case for this was not FETCH, but
> MOVE for > 2gig tables.

There is *no* credible use case for this (hint: MOVE FORWARD/BACKWARD
ALL does not need this to work for >2G tables).  It is not worth the
extra computational cycles that it imposes on every machine whether they
use the feature or not, and it is certainly not worth the developer time
we're expending to fix this poorly written patch.  Please revert it.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-09-03 03:24:40
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Change FETCH/MOVE
Previous:From: Bruce MomjianDate: 2006-09-03 03:08:27
Subject: Re: ecpg regression broken

pgsql-committers by date

Next:From: Bruce MomjianDate: 2006-09-03 03:24:40
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Change FETCH/MOVE
Previous:From: Bruce MomjianDate: 2006-09-03 03:19:45
Subject: pgsql: Revert FETCH/MOVE int64 patch.

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-09-03 03:24:40
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Change FETCH/MOVE
Previous:From: Bruce MomjianDate: 2006-09-03 01:58:52
Subject: Re: Predicate Locking

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group