Skip site navigation (1) Skip section navigation (2)

Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>
Cc: Lionel Elie Mamane <lionel(at)mamane(dot)lu>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**
Date: 2011-09-20 23:43:25
Message-ID: 8393.1316562205@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Craig Ringer <ringerc(at)ringerc(dot)id(dot)au> writes:
> As for wording: my *personal* preference is "const char * const" but I 
> don't know what the opinions of those who work with the code day-to-day are.

+1.  Isn't the other ordering deprecated by recent C standards?
(Or maybe I'm just thinking of where you're supposed to put "static",
but in any case "char const *" looks pretty weird to me.)  Also,
the existing usages in libpq-fe.h look like that, and there's no good
reason for these to be randomly different.

			regards, tom lane

In response to

pgsql-bugs by date

Next:From: pratikchiraniaDate: 2011-09-21 07:16:58
Subject: Re: Timezone issues with Postrres
Previous:From: Craig RingerDate: 2011-09-20 23:29:23
Subject: Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group