Re: PGRES_POLLING_ACTIVE is unused...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Lennert Buytenhek <buytenh(at)gnu(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: PGRES_POLLING_ACTIVE is unused...
Date: 2003-03-03 05:38:09
Message-ID: 813.1046669889@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Lennert Buytenhek <buytenh(at)gnu(dot)org> writes:
> ...any reason why it is there at all?

Good question. Some digging in CVS shows that it was unused even in the
patch that introduced it, and never has been used in any release since.
So it does seem like useless complication.

However, I think it'd be unwise to remove the constant from libpq-fe.h,
because that would break the application of any poor sod who believed
the documentation and wrote code that actually checks for
PGRES_POLLING_ACTIVE.

I'd be inclined to remove it from the documentation and the library
innards, but leave something like this in libpq-fe.h:

PGRES_POLLING_ACTIVE /* unused; keep for awhile for
* backwards compatibility */

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Oliver Elphick 2003-03-03 06:29:48 psql patch for datestyle
Previous Message Rod Taylor 2003-03-03 04:34:23 ALTER SEQUENCE