Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Fred Yankowski <fred(at)ontosys(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-04 19:01:17
Message-ID: 8088.986410877@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-ports
Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com> writes:
>     1. I'm not crazy about the name FE_DLLLIBS -- I don't think that it
>        accurately represents its semantics.

Okay.

>        (I presume that you meant
>        that FE_DLLLIBS = -lcygipc -lcrypt; otherwise, I'm not grokking
>        your proposal.)

Right, given that the other two need not be mentioned.  What about
-L/usr/local/lib, did that make any sense to include or not?

> What about leaving DLLLIBS as defined (in Makefile.win) in my patch, but
> also defining BE_DLLLIBS as follows:
>     BE_DLLLIBS = -L$(top_builddir)/src/backend -lpostgres
> Then one can use this definition is in src/pl/plpgsql/src/Makefile as
> follows:
>     DLLLIBS:= $(BE_DLLLIBS) $(DLLLIBS)
> The above would also be used where ever else was necessary (e.g.,
> regress.dll).

> How does this proposal sound?

Works for me.  Given that we'd like to package RC3 tonight, it'd be nice
to get this done ASAP.  Do you have time to work up and test a patch
today, or shall I risk making untested changes myself?

			regards, tom lane

In response to

Responses

pgsql-ports by date

Next:From: Jason TishlerDate: 2001-04-04 19:27:43
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Gregor GoldbachDate: 2001-04-04 18:45:24
Subject: PostgreSQL and Microsoft Visual C

pgsql-patches by date

Next:From: Jason TishlerDate: 2001-04-04 19:27:43
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Jason TishlerDate: 2001-04-04 18:39:53
Subject: Re: Re: [PATCHES] patch for minor Win32 makefile bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group