Skip site navigation (1) Skip section navigation (2)

Re: patch for cleanup protocol

From: tomas(at)nocrew(dot)org (=?iso-8859-1?q?Tomas_Sk=E4re?=)
To: Ludek Finstrle <luf(at)pzkagis(dot)cz>
Cc: pgsql-odbc(at)postgresql(dot)org
Subject: Re: patch for cleanup protocol
Date: 2005-12-20 08:42:50
Message-ID: 803bkognw5.fsf@junk.nocrew.org (view raw or flat)
Thread:
Lists: pgsql-odbc
Ludek Finstrle <luf(at)pzkagis(dot)cz> writes:

> Hello,
>
>   protocol option is no longer used with libpq driver version.
> So I clean up the code. I try change both languages (English and Japanese).
> I didn't sure how to clean up faq.html so I don't do it.
>
> Please review and comment

I'm not qualified to tell if the changes are correct, but I just
noticed this one thing:

> diff -c psqlodbc.orig\dlg_specific.c psqlodbc.full\dlg_specific.c
> *** psqlodbc.orig\dlg_specific.c	Wed Nov 30 13:44:16 2005
> --- psqlodbc.full\dlg_specific.c	Mon Dec 19 23:33:09 2005
> ***************
> *** 65,72 ****
>   				";%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%s;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d;%s=%d",
>   				INI_READONLY,
>   				ci->onlyread,
> - 				INI_PROTOCOL,
> - 				ci->protocol,
>   				INI_FAKEOIDINDEX,
>   				ci->fake_oid_index,
>   				INI_SHOWOIDCOLUMN,
> --- 65,70 ----

If you remove these arguments, you have to remove the corresponding
(second from start) "%s=%s" pair from the format string, otherwise
it'll use the wrong variables for the %d's further on.


Tomas

In response to

Responses

pgsql-odbc by date

Next:From: AndrusDate: 2005-12-20 09:31:10
Subject: Re: [ psqlodbc-Bugs-1000481 ] VFP and SQLCancel
Previous:From: Dave PageDate: 2005-12-20 08:15:15
Subject: Re: patch for cleanup protocol

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group