Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> writes:
> 2012/7/3 Robert Haas <robertmhaas(at)gmail(dot)com>:
>> Why not just save and restore the user ID and security context
>> unconditionally, instead of doing this kind of dance?
>>
>> + if (portal->userId != GetUserId())
>> + SetUserIdAndSecContext(portal->userId, portal->secCo
>> + else
>> + saveUserId = InvalidOid;
>>
> In case when CurrentUserId was updated during the code block
> (E.g, execution of SET SESSION AUTHORIZATION), it overwrites
> this update on restoring user-id and security-context.
Um... what should happen if there was a SET SESSION AUTHORIZATION
to the portal's userId? This test will think nothing happened.
regards, tom lane
In response to
Responses
pgsql-hackers by date
| Next: | From: Tom Lane | Date: 2012-07-03 15:41:09 |
| Subject: Re: Posix Shared Mem patch |
| Previous: | From: Andres Freund | Date: 2012-07-03 15:36:24 |
| Subject: Re: Posix Shared Mem patch |