Re: [COMMITTERS] pgsql-server/src backend/commands/variable.c b ...

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Maybe on your machine we need to include <sys/time.h> or some such?

> I just checked using grep on all my /usr/include files, and can't find
> tzname anywhere, but it is in libc. I added a line to port/bsdi.h to
> fix it, but I am not sure that is the correct solution.

I looked at the autoconf macro that tests for existence of tzname[],
and saw that it explicitly does

#ifndef tzname /* For SGI. */
extern char *tzname[];
#endif

after including <time.h>. So it seems that they are expecting some
systems not to provide a declaration for tzname even though they have it.

I have checked in a fix that does #ifdef HAVE_TZNAME, and includes
a declaration as above. (Without the declaration, we would fail anyway
on machines that are like this.) So you shouldn't need the port/bsdi.h
hack anymore.

regards, tom lane