From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | "Decibel!" <decibel(at)decibel(dot)org>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org, Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
Subject: | Re: temporary statistics option at initdb time |
Date: | 2008-08-19 18:34:55 |
Message-ID: | 7903.1219170895@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Actually, I think maybe not so hard. Attached is a patch that fixes
> this. It's done by keeping the old filename around. When you change the
> path, the stats collector will start writing the new file the next time
> it writes something (which should be max 0.5 seconds later if something
> is happening). The backends will immediately try to read from the new
> filename, but if that one is not found, they will switch to reading the
> old filename. This obviously fails if you change the temp directory
> twice in less than half a second, but I really don't see a use-case for
> that...
I think this is introducing complication and race conditions to solve a
problem that no one will really care about. Just let people change the
filename at SIGHUP and document that doing that on-the-fly may cause
stats queries to fail for a short interval.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Hannu Krosing | 2008-08-19 18:35:21 | Re: Adjusting debug_print_plan to be more useful by default |
Previous Message | Bruce Momjian | 2008-08-19 18:34:47 | Re: Patch: plan invalidation vs stored procedures |