Skip site navigation (1) Skip section navigation (2)

Re: pre-MED

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, Hannu Krosing <hannu(at)krosing(dot)net>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pre-MED
Date: 2008-12-15 18:36:39
Message-ID: 7741.1229366199@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
David Fetter <david(at)fetter(dot)org> writes:
> On Mon, Dec 15, 2008 at 08:50:25AM -0500, Tom Lane wrote:
>> I'm sorry, but I have far too much work in front of me reviewing
>> patches that have a chance of getting into 8.4.  I do not have time
>> to do pre-implementation research for a patch that doesn't.

> You took on the responsibility by rejecting the working patch and
> saying how it should be implemented.

"Working"?  What you submitted was a self-acknowledged crude hack,
which was shortly shown to have several major problems; a quick look
in the archives suggests
	* fails on subplans, and possibly other things that ruleutils.c
	  doesn't support well
	* not at all clear what to do with aliased column names
	* requires custom support in each PL, only one of which was
	  actually implemented
and there are probably more (I didn't reread the whole thread).  The
fact that I suggested a possible avenue to fixing some of those problems
doesn't make it my responsibility to fix them ... especially not if I
don't particularly approve of the hack in the first place.  Even with
all this fixed it would be a dead-end feature, but we'd be stuck with
supporting it forever.  You should be happy that I was willing to hold
still for accepting the patch if the problems got fixed.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Gregory StarkDate: 2008-12-15 18:46:43
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1
Previous:From: Joshua D. DrakeDate: 2008-12-15 18:02:42
Subject: Re: pre-MED

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group