Skip site navigation (1) Skip section navigation (2)

Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Date: 2010-09-28 22:37:13
Message-ID: 756.1285713433@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> OK, I used your idea for conversion directly to oid from the system
> catalogs, patch attached.  All the pg_controldata returned integers are
> defined as uint32 in pg_upgrade. Should I use atooid() for some of them
> and define some of them as OID?

No, I don't think so --- most of them are not in fact OIDs.  Probably
best to follow what pg_control.h declares them as.

			regards, tom lane

In response to

pgsql-committers by date

Next:From: Bruce MomjianDate: 2010-09-29 02:40:47
Subject: pgsql: Have pg_upgrade use strtoul(), not strtol().
Previous:From: Bruce MomjianDate: 2010-09-28 22:14:23
Subject: Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group