Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail
Date: 2005-03-02 05:38:59
Message-ID: 7371.1109741939@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Have we considered what is going to happen to applications when they use
> our snprintf instead of the one from the operating system?

Hmm ...

First line of thought: we surely must not insert a snprintf into
libpq.so unless it is 100% up to spec *and* has no performance issues
... neither of which can be claimed of the CVS-tip version.

Second line of thought: libpq already feels free to insert allegedly
up-to-spec versions of a number of things, and no one has complained.
Maybe the linker prevents problems by not linking these versions to
any calls from outside libpq?

Third thought: Windows' linker seems to be broken enough that it may
create problems of this ilk that exist on no other platform.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-02 06:06:35 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail
Previous Message Bruce Momjian 2005-03-02 05:22:14 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-02 06:06:35 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail
Previous Message Bruce Momjian 2005-03-02 05:22:14 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests

Browse pgsql-patches by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-02 06:06:35 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail
Previous Message Bruce Momjian 2005-03-02 05:22:14 Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests